Update an item causes recursive loop

RE: Update an item causes recursive loop

Morgan — Thu, 13 Oct 2022 14:49:53 GMT

It's possible. I did end up getting everything working.

I ended up creating a client wrapper as a method triggered from a form event onFormPopulate. The client method validates that the item is locked then calls the server method to perform the update. It's working as expected now.

RE: Update an item causes recursive loop

Morgan — Thu, 13 Oct 2022 14:47:35 GMT

Thanks for the suggestion, I never considered that. I'll run a test on this in the future but I've got it working another way.

RE: Update an item causes recursive loop

alaxala — Thu, 13 Oct 2022 11:40:01 GMT

Why not to use OnBeforeUpdate? In this case you don't need an additional update. Just change the properties of "this".

this.setProperty("a_gpr_by_prodcat", setRegions);
this.setProperty("a_design_center", setRegions);
if (this.getProperty("a_eco_status") == null)
{
    this.setProperty("a_eco_status", "Stage 1 of 11 - ECR Created");
}
return this;

RE: Update an item causes recursive loop

AngelaIp — Thu, 13 Oct 2022 10:45:13 GMT

I used this code in ItemType 'Manufacturer' as onAfterUpdate Method and it updated the 'name' property without server crash:

this.setAction("edit");
this.setAttribute("serverEvents","0");
this.setProperty("name","myupdatedname");
Item result = this.apply();

return result;

Maybe some other Method influence your current one. Maybe LifeCylce Method? Or do you automatic revision mode?

RE: Update an item causes recursive loop

Morgan — Wed, 12 Oct 2022 17:04:16 GMT

Maybe I am doing something wrong with the serverEvents attribute?

That is correct. I am editing the same item that is saved.

Oddly, my wrapper method doesn't refresh the form but it still loops :/

I didn't want to use sql because I wanted the history to show when this value gets updated (Its the product category for our changes)

Here is the portion of the code in question, the server events is commented out due to me changing over to the onAfterVersion in my original testing since it didnt work:

    ecrItem.setAction("update");
    
    WriteLog("ECR in Edit Mode - Item Lock Status = "+ecrItem.getLockStatus()+" Item ID "+ecrItem.getID());
    // ecrItem.setAttribute("serverEvents", "0");
    ecrItem.setAttribute("version", "0");
    ecrItem.setProperty("a_gpr_by_prodcat", setRegions);
    ecrItem.setProperty("a_design_center", setRegions);
    if (ecrItem.getProperty("a_eco_status") == null)
        {
            ecrItem.setProperty("a_eco_status", "Stage 1 of 11 - ECR Created");
        }
    ecrItem = ecrItem.apply();

RE: Update an item causes recursive loop

AngelaIp — Wed, 12 Oct 2022 16:52:02 GMT

Strange, I was sure that serverEvents would do the trick. It´s often combined with setAttribute("doGetItem","0"); , but it should not make a difference.

So you basically have an ItemType like e.g. "Part". After clicking save your Method will edit something in the same item. Correct?

onFormPopulates will trigger the loop if you refresh the Form in your Method.

I have to admit, when ever I update something after regular edit, I don´t use AML but SQL. This is also what Aras does a lot. This way you prevent unnecessary history entries.

RE: Update an item causes recursive loop

Morgan — Wed, 12 Oct 2022 16:31:22 GMT

Yep, that was one of the first things I tried with onAfterUpdate to stop it calling the method recursively but it didn't seem to work.

Funny enough, when using onAfterVersion I was able to use setAttribute("version","0"); and was able to stop it which is why I switched over to that trigger but it caused other issues as I noted.

RE: Update an item causes recursive loop

AngelaIp — Wed, 12 Oct 2022 16:19:05 GMT

Have you tried the attribute serverEvent = 0 in your query?

Edit: --> myCall.setAttribute("serverEvents","0");

RE: Update an item causes recursive loop

Morgan — Wed, 12 Oct 2022 16:15:02 GMT

Thanks for this Angela. The system does definitely collapse :) I don't know that this will work for my case. In the example here, once the property is set the method will not fire again. In my use case, I need the method to fire and update the property everytime the item is saved. If I use this method, it will apply the first time but then not in any subsequent attempts I believe.

RE: Update an item causes recursive loop

AngelaIp — Wed, 12 Oct 2022 16:07:51 GMT

Cool! What is the practical effect of the loop? Will the system collapse?

Recursive loops can be prevented with fake properities: https://community.aras.com/b/english/posts/tech-tip-utilizing-fake-properties

Hope this helps!